This repository was archived by the owner on Jun 17, 2025. It is now read-only.
Pull Request: Enhanced Modularity and Customizable Shortcuts#132
Open
katzkuma wants to merge 3 commits into
Open
Pull Request: Enhanced Modularity and Customizable Shortcuts#132katzkuma wants to merge 3 commits into
katzkuma wants to merge 3 commits into
Conversation
This commit refactors the code to extract the initialization of the menubar instance (mb) into a separate module called 'menubar.js'. By moving the menubar creation logic to its own module, I'm gonna to create customized shortcut function later. Changes Made: - Moved menubar instance creation logic from main.js to mbManager.js. - Updated index.js to import and use the createMenubar function from menubar.js. - Adjusted otherScript.js to import and use the getMenubarInstance function from mbManager.js.
…enhanced settings view To enhance user experience and provide greater customization options, this commit introduces a new feature allowing users to define custom shortcuts. Additionally, a new settings view has been developed to streamline the process of configuring shortcut. Here's a breakdown of the changes made: Changes Made: - New settings view with index.html and index.css - Integration of 'electron-settings' Package - Creation of `settings.js` Module for handling settings view
|
@vincelwt can you merge this please? Kinda annoying that CMD+Shift+G is exclusively held by your app, when it is used by many other apps and people need to break their habits now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances code modularity and introduces customizable shortcuts for improved user experience. Here's a summary of the changes:
Code Modularity:
Customizable Shortcuts and Enhanced Settings View:
These changes improve code organization and user interaction, setting the stage for future enhancements. Your review and feedback are welcome.
These are related issues:
#90
#47
#77
#112