mrc-6404 Fix for latest packit #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
changed the title
EmmaLRussell
commented
Apr 15, 2025
| on: | ||
| schedule: |
There was a problem hiding this comment.
Not sure why this was running on a schedule, doesn't feel like we need it now!
richfitz
approved these changes
Apr 16, 2025
| name: packit | ||
| tag: mrc-4261 | ||
| name: montagu-packit | ||
| tag: mrc-5140-trusted-headers |
There was a problem hiding this comment.
how do you want to handle the merge order here? Keep this for now as mrc-ide/packit#187 is in draft?
There was a problem hiding this comment.
Yeah, for the moment. Looks like that's what we did before!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small fixes to get orderly-web-deploy working with current packit so we can test alongside each other:
montagu-packitdocker image which sets base urls for/packitand/packit/api.auth.enabledto false! I'm assuming that any Packit deployed via OrderlyWeb will be done in non-prod environments at this point, which are not publicly accessible, so it should be ok to disable auth. Montagu authentication will be applied to Packit deployed alongside Montagu on VIMC prod when available (via Montagu deploy).There is one issue I'm not quite sure how to deal with - I was intermittently seeing the orderly server container failing to start up, and tests were consistently failing apparently for this reason. Looking at the container logs, it seemed that this was due to the sqlite database being locked when the container was attempting to back it up. I wondered if this might be because of outpack server also trying to use it... Currently I've "fixed" the test failures by adding a 5s wait into the constellation when it starts up orderly server to give it time to do the backup before starting outpack server.. but perhaps this isn't sufficient for a real server with real data. We could add a "wait-for-db-backup" script to orderly server? Or could maybe do more checks from the constellation?
To test manuallly:
orderly-web start config/packitOnce this is merged I'll push a new version to PyPI and test that out with montagu-orderly-web on uat.