Update for new constellation deployment. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
force-pushed
the
VIMC-7152-plietar
branch
from
fc0e523 to
f6a1ac2
Compare
EmmaLRussell
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Works for me!
Does this mean we can now close PR #84?
Unrelated to your changes, but I noticed that ./scripts/dev.sh wasn't honouring the data parameter as described in README ("Build and run locally") - should just need to change line 31 of dev.sh to $here/run-dependencies.sh "$1".
This is picking up changes from PR #84. The constellation based deployment uses dashes as the container name separator, which needs some updating in the nginx file. To make this repository test environment work, we switch to docker compose v2 which uses the same names. It seems the static file paths weren't needed anymore, so these bits are removed.
plietar
force-pushed
the
VIMC-7152-plietar
branch
from
f6a1ac2 to
5e42c07
Compare
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is picking up changes from PR #84.
The constellation based deployment uses dashes as the container name separator, which needs some updating in the nginx file. To make this repository test environment work, we switch to docker compose v2 which uses the same names.
It seems the static file paths weren't needed anymore, so these bits are removed.