Remove public cache-controls (fixes settings override, and perhaps shouldn't be there anyway) #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richfitz
reviewed
Mar 31, 2023
There was a problem hiding this comment.
Suggest reducing duplication here by using the include command: http://nginx.org/en/docs/ngx_core_module.html#include
|
Yes - we could do that - or perhaps even easier: Could |
|
Tested on prod2 - the HSTS header seems correctly set, and everything appears to be working. |
weshinsley
changed the title
weshinsley
changed the title
richfitz
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure HSTS turns on by copying
add_headerto places where it otherwise would not get inherited.See https://mrc-ide.myjetbrains.com/youtrack/issue/VIMC-7074
and https://www.nginx.com/blog/http-strict-transport-security-hsts-and-nginx/