fix: Use @denops/std/helper/getbufinfo instead #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 50.63% 50.65% +0.02%
==========================================
Files 77 77
Lines 2277 2278 +1
Branches 67 67
==========================================
+ Hits 1153 1154 +1
Misses 1124 1124 ☔ View full report in Codecov by Sentry. |
The getbufinfo function in @denops/std/function will raise an error when there's a funcref in buffer-local variables, and we should switch to the alternative getbufinfo function provided by @denops/std/helper/getbufinfo.
mityu
force-pushed
the
use-helper-getbufinfo
branch
from
48c529c to
bd568d2
Compare
|
Fixed lint errors and rebased the main branch. |
lambdalisue
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: vim-denops/deno-denops-std#279
As you know, the getbufinfo function in @denops/std/function will raise an error when there's a funcref in buffer-local variables. So, we should switch to the alternative getbufinfo function provided by @denops/std/helper/getbufinfo module.
I searched for "getbufinfo" by
rg getbufinfoat the root of this repository, and changed all of them to the helper module's getbufinfo function.