Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr chartjs plugins #875

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

mhspelt
Copy link
Contributor

@mhspelt mhspelt commented Sep 12, 2024

Hi @gvreddy04
Here's another pull request that adds built-in support for two common chart.js plugins: annotations and zoom.
In addition it allows the user to load any additional plugins without modifying the library, the documentation shows an example for the dragdata plugin.

Note that the documentation for this pull request and my previous one (time scales) requires external libraries to be loaded for the demo to work.

@Alessio92
Copy link

Ciao!
It looks like you've done a great job. Could you update the MR by aligning the commits who conflict?

I think it would be helpful for everyone if it got accepted.

@mhspelt
Copy link
Contributor Author

mhspelt commented Feb 18, 2025

Ciao! It looks like you've done a great job. Could you update the MR by aligning the commits who conflict?

I think it would be helpful for everyone if it got accepted.

I have about 5 more PR's outstanding on this project, I'm currently using my own fork and was not planning to spend too much time unless there is an intention of actually merging. But I think the only conflict here was in a documentation page so I just used main's version.

@Alessio92
Copy link

Alessio92 commented Feb 18, 2025

Hello @gvreddy04,

This pull request would be very useful for both me and others. What do you still need to be able to approve it?

regards,

@gvreddy04
Copy link
Contributor

gvreddy04 commented Feb 18, 2025

Feedback: Move the chart components to a seperate component library #1046

@mhspelt @Alessio92 Plsease share your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants