Skip to content

Comments

Assignment 1 complete#1

Open
vignash46 wants to merge 2 commits intomainfrom
assignment-1
Open

Assignment 1 complete#1
vignash46 wants to merge 2 commits intomainfrom
assignment-1

Conversation

@vignash46
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding updated assignment 1 jupyter notebook file

What did you learn from the changes you have made?

How to use KNN training and testing models

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Nope, first time doing this

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Nope, was pretty straightforward

How were these changes tested?

Ran the code step by step in VS Code

A reference to a related issue in your repository (if applicable)

None

Checklist

  • I can confirm that my changes are working as intended

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1: Resubmission required. Needs a few changes.
Required Changes:
Q1)
When answering questions rather then commenting in after manually reading the output, should automate it. for eg.

Number of observations (rows)
num_observations = wine_df.shape[0]
print(f"Number of observations: {num_observations}")

Q1)II)Can use the code “num_observations = wine_df.shape[1]” to access number of variables/columns

Q1)III) The type of variable is categorical. In a data science setting, this question is asking whether the variable is continuous or categorial(integer, ordinal are other options).
Q3) No Output

Q4) No output

@vignash46
Copy link
Owner Author

Made all the changes, thank you for the feedback!

Copy link

@PatelVishakh PatelVishakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment 1 Complete! Great Edits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants