-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optional Authorization Code Flow #8
base: master
Are you sure you want to change the base?
Conversation
Is this intended to be a starting point for using the beta 23 sdk? Including it sets off a lot of errors on other functions not related to auth. |
No this PR should not have to do anything with SDK 23. As you can see in the changes, I have only added "tokenSwapURL" and "tokenRefreshURL" in |
I have also renamed SpotifyModule -> SpotifyAuth in README, because SpotifyModule does not exist and seem to be some legacy code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like using an object with options for Auth, awesome job!
I need you to change a couple things before I merge this. it would be nice to only set tokenSwapURL
and tokenRefreshURL
only if the user provides them, so maybe add a condition for that.
In the README file, please change back SpotifyAuth
to SpotifyModule
as I will change it in the code too.
Please forgive the late review but I have been super busy this past month.
Thank you so much for your contributions and your patience!
No description provided.