Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated castlevania.yaml #56

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Conversation

eldri7ch2
Copy link
Contributor

Description

Updated and corrected information about Symphony of the Night Randomizers.

Updated with all version s of all randomizers for SOTN
Also added the tutorial site
Condensed the entire PS1 version of the SOTN randomizer for easier reading
@eldri7ch2
Copy link
Contributor Author

I am so lost. Somehow I still had some of the issues?

@eldri7ch2
Copy link
Contributor Author

BTW, front-end coding is not my forté

@Die4Ever
Copy link
Member

Die4Ever commented Dec 4, 2024

you can access the results of the automation by clicking the Details, or just run the validation script on your own computer

Castlevania.yml: undefined games in SOTN Area Rando (SOTN AR) : Castlevania: Symphony of the Night (PlayStation / Saturn / PSP)

that's not a real game title, ditch the list of platforms like I did on your other pull request

Fixed title issues.
Copy link
Contributor Author

@eldri7ch2 eldri7ch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved platforms to Identifiers

Re-Re-updated titles.
Copy link
Contributor Author

@eldri7ch2 eldri7ch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Learning process. My bad.

Just removing parentheticals altogether.
Copy link
Contributor Author

@eldri7ch2 eldri7ch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One day I will make something valid.

@eldri7ch2
Copy link
Contributor Author

eldri7ch2 commented Dec 4, 2024

OK, in the latest file I have completely removed the lists and moved them all into the comments and yet I still have it not being approved. What else did I do wrong, here?

@Die4Ever
Copy link
Member

Die4Ever commented Dec 4, 2024

Castlevania.yml: unused games: Castlevania: Symphony of the Night (PlayStation / Saturn)

so it needs to be removed from the games list at the top

@eldri7ch2
Copy link
Contributor Author

Not there when I view it:

image

@eldri7ch2
Copy link
Contributor Author

When I do the file reviews, am I viewing a different file? If so, how do I replace what is being reviewed?

@Die4Ever
Copy link
Member

Die4Ever commented Dec 4, 2024

line 47

Edited line 47 to remove console list
Copy link
Contributor Author

@eldri7ch2 eldri7ch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed console list from line 47

@eldri7ch2
Copy link
Contributor Author

That made no sense, I didn't even edit that line. Anyway, now it passed.

updated-date: 2024-08-21
- 'Castlevania: Symphony of the Night'
identifier: "Castlevania: SOTN Randomizer"
url: https://symphonyrando.fun
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this url doesn't work https://symphonyrando.fun

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the www after //. My bad, i forget that all the time because it was a recent requirement change

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the actual URL is https://www.symphonyrando.fun/ with the www

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah

Copy link
Contributor Author

@eldri7ch2 eldri7ch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added www.

comment: "MottZilla's Randomizer for the XBLA version of SOTN Includes many of the same presets as the PlayStation's community version. Only works with the Canary build of the Xenia emulator or on Modded X-Box 360's."
updated-date: 2024-12-03
added-date: 2024-12-03
opensource: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/MottZilla/SOTN_XB_RANDO does not appear to include source code for the randomizer

Suggested change
opensource: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O, damn. I thought it did. Maybe he didn't want his spaghetti code all over. Lemme fix that.

Removed opensource flag from XBLA SOTN Rando
Copy link
Contributor Author

@eldri7ch2 eldri7ch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed opensource flag from XBLA SOTN Rando

@Die4Ever Die4Ever merged commit b19a026 into video-game-randomizers:main Dec 4, 2024
3 checks passed
@Die4Ever
Copy link
Member

Die4Ever commented Dec 4, 2024

your updates are now live, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants