Detect and work-around stuck-reconnection issue

victronenergy · Nov 3, 2023 · fa53a6e · fa53a6e · jhofstee · Nov 5, 2023
1 parent 7b63d59
commit fa53a6e
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/src/qt/ve_qitems_mqtt.cpp b/src/qt/ve_qitems_mqtt.cpp
@@ -283,6 +283,21 @@ void VeQItemMqttProducer::onConnected()
 			this, &VeQItemMqttProducer::onSubscriptionMessageReceived, Qt::UniqueConnection);
 		doKeepAlive();
 	}
+
+	// QMqttClient has some internal state which sometimes isn't cleaned up
+	// properly on disconnection.  To allow reconnection, we need to delete
+	// the client, transition back to idle state, and then reconnect.
+	QTimer::singleShot(3000, this, [this] {
+		// If we're still waiting to receive a message from the broker more
+		// than 3 seconds after connecting, assume we are in the stuck state.
+		if (connectionState() == VeQItemMqttProducer::Connected) {
+			qWarning() << "Automatic reconnection failed, trying clean reconnect.";
+			mMqttConnection->deleteLater();
+			mMqttConnection = nullptr;
+			setConnectionState(Idle);
+			open(QHostAddress(mHostName), mPort);
+		}
+	});
 }
 
 void VeQItemMqttProducer::onDisconnected()