Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1899 tank config parameters cant be set on arm build #1913

Merged

Conversation

DanielMcInnes
Copy link
Contributor

No description provided.

@DanielMcInnes DanielMcInnes linked an issue Feb 18, 2025 that may be closed by this pull request
@DanielMcInnes DanielMcInnes force-pushed the 1899-tank-config-parameters-cant-be-set-on-arm-build branch 3 times, most recently from 46bb3c7 to 0dc0ee9 Compare February 18, 2025 04:00
Copy link
Contributor

@chriadam chriadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, LGTM.

When writing values to dbus, if the underlying dbus type is 'integer', convert
the new value to 'integer' before sending the message to dbus.

Fixes #1899
@DanielMcInnes DanielMcInnes force-pushed the 1899-tank-config-parameters-cant-be-set-on-arm-build branch from 0dc0ee9 to cdd85d9 Compare February 18, 2025 04:38
@DanielMcInnes DanielMcInnes merged commit 9d713b0 into main Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tank config parameters can’t be set in some situations
2 participants