feat(ui): raise Settings window and filter provider order to configured - #38
Merged
Conversation
Introduce `openAndRaiseSettings` to bring the Settings window forward on every click instead of only on first open. Filter the Appearance tab's "Provider order" list to show only configured providers, matching the popover's visible set, and show a hint when nothing is configured. Add unit tests for the new view-model computed property.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two Settings-window papercuts: re-clicking "Settings…" now raises the already-open window instead of leaving it behind the frontmost app, and the Appearance tab's "Provider order" list shows only providers that are actually configured.
Why
Two user-facing bugs (ui 16). The Settings window could get lost behind other apps when re-opened, and the provider order list included every registered provider regardless of whether the user had set it up.
What changed
SettingsLinkwith a custom button modifier that callsopenSettings(), activates Filbert, and explicitly raises the SettingsNSWindow. The window lookup uses structural traits (styleMask.contains(.titled)and notNSPanel) instead of localized title text, so it works across locales.configuredProvidersOrderedtoQuotaViewModel, filtered by the same state predicate used inrefreshDerived(). The Appearance tab now renders this filtered list and shows an empty-state hint when no providers are configured.configuredProvidersOrderedacross mixed configured/unconfigured registries.Notes for review