Fix weird issue in images build with typings (plone#6471)

.eslintrc.cjs

@@ -56,6 +56,7 @@ const config = {
       ],
       rules: {
         '@typescript-eslint/no-explicit-any': 'off',
+        '@typescript-eslint/ban-ts-comment': 0,
       },
     },
     {

packages/registry/.eslintrc.cjs

@@ -74,6 +74,7 @@ module.exports = {
       },
       rules: {
         'no-prototype-builtins': 0,
+        '@typescript-eslint/ban-ts-comment': 0,
       },
     },
   ],

packages/registry/news/6471.bugfix

@@ -0,0 +1 @@
+Fix weird typings issue happening in docker build but not locally. @sneridagh

packages/registry/src/addon-registry/create-addons-loader.ts

@@ -125,8 +125,7 @@ export function createAddonsLoader(
   }
 
   const code = getAddonsLoaderCode(addons, addonsInfo, loadProjectConfig);
-  // @ts-expect-error No clue why it's complaining
-  fs.writeFileSync(addonsLoaderPath, Buffer.from(code));
+  fs.writeFileSync(addonsLoaderPath, code);
   return addonsLoaderPath;
 }
 

packages/registry/src/addon-registry/create-theme-loader.ts

@@ -22,7 +22,10 @@ function nameFromPackage(name: string) {
  * Creates a static file with code necessary to load the addons configuration
  *
  */
-function getThemeLoaderCode(name: string, customThemeAddons = []) {
+function getThemeLoaderCode(
+  name: string,
+  customThemeAddons: Array<string> = [],
+) {
   let buf = `/*
 This file is autogenerated. Don't change it directly.
 Add a ./theme/_${name}.scss in your add-on to load your theme customizations in the current theme.
@@ -49,14 +52,9 @@ export function createThemeAddonsLoader({
   const addonsThemeLoaderMainPath = tmp.tmpNameSync({ postfix: '.scss' });
   fs.writeFileSync(
     addonsThemeLoaderVariablesPath,
-    //@ts-expect-error No clue why this is erroring
-    new Buffer.from(getThemeLoaderCode('variables', variables)),
-  );
-  fs.writeFileSync(
-    addonsThemeLoaderMainPath,
-    //@ts-expect-error No clue why this is erroring
-    new Buffer.from(getThemeLoaderCode('main', main)),
+    getThemeLoaderCode('variables', variables),
   );
+  fs.writeFileSync(addonsThemeLoaderMainPath, getThemeLoaderCode('main', main));
 
   return [addonsThemeLoaderVariablesPath, addonsThemeLoaderMainPath];
 }