Skip to content

ci: add live Docker workbench smoke #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vibeforge1111 merged 1 commit into from
May 27, 2026
Merged

ci: add live Docker workbench smoke #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .github/workflows/docker-optional.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,28 @@ jobs:
--tmpfs /sandbox:rw,nosuid,size=512m \
spark-cli-sandbox:ci \
--help

live-smoke:
name: live-smoke
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- name: Checkout
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
with:
persist-credentials: false

- name: Build live image
run: docker build -f docker/live/Dockerfile -t spark-live:ci .

- name: Run live CLI smoke
run: docker run --rm --user spark --entrypoint spark spark-live:ci --help

- name: Verify live entrypoint fails closed without hosted env
run: |
set +e
docker run --rm spark-live:ci >spark-live-entrypoint.out 2>&1
status="$?"
set -e
test "$status" -eq 2
grep -q "SPARK_LLM_PROVIDER is required" spark-live-entrypoint.out
5 changes: 4 additions & 1 deletion docs/OPTIONAL_DOCKER_WORKBENCH.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ This repo provides two opt-in Docker lanes:
|---|---|---|---|
| Dev smoke | `docker/dev/Dockerfile` | Clean disposable environment for tests and installer verification | On |
| Sandbox run | `docker/sandbox/Dockerfile` | Restricted CLI command experiments with no real home or secrets | Off |
| Live image smoke | `docker/live/Dockerfile` | Hosted Spark Live image build and entrypoint guard checks | Hosted env only |

Use these when you want to test a new feature without contaminating the operator's real `~/.spark` state.

Expand Down Expand Up @@ -138,7 +139,9 @@ Network-on sandbox runs should be treated as a separate risk decision.

## Optional GitHub Workflow

The manual workflow at `.github/workflows/docker-optional.yml` builds both images and runs a smoke command. It only runs through `workflow_dispatch`, so Docker does not become a required CI dependency.
The manual workflow at `.github/workflows/docker-optional.yml` builds the dev,
sandbox, and live images and runs bounded smoke commands. It only runs through
`workflow_dispatch`, so Docker does not become a required CI dependency.

## Secret Rules

Expand Down
Loading