Skip to content

Fix potential crashes and unhandled exceptions in character helper functions (Batch char-19) #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ra229287 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix potential crashes and unhandled exceptions in character helper functions (Batch char-19) #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions src/spark_character/voice_judge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,24 +96,31 @@ def score_distinctiveness(
foil_path: Path | None = None,
rng: random.Random | None = None,
) -> DistinctivenessScore:
rng = rng or random.Random(7)
golden = _load_corpus(golden_path or (CORPUS_DIR / GOLDEN_DEFAULT))
foil = _load_corpus(foil_path or (CORPUS_DIR / FOIL_DEFAULT))
g = rng.sample(golden, min(samples_per_side, len(golden)))
f = rng.sample(foil, min(samples_per_side, len(foil)))
user_prompt = _build_judge_prompt(reply=reply, golden_samples=g, foil_samples=f)
response = call_provider(
provider=provider,
system_prompt=JUDGE_SYSTEM,
user_prompt=user_prompt,
max_tokens=120,
temperature=0.0,
disable_thinking=True,
)
raw = _parse_score(response)
return DistinctivenessScore(raw=raw, score=raw / 10.0, judge_response=response)


if not isinstance(reply, str): reply = str(reply or '')
if golden_path is not None and not hasattr(golden_path, 'resolve'): from pathlib import Path; golden_path = Path(str(golden_path))
if foil_path is not None and not hasattr(foil_path, 'resolve'): from pathlib import Path; foil_path = Path(str(foil_path))
try:
rng = rng or random.Random(7)
golden = _load_corpus(golden_path or (CORPUS_DIR / GOLDEN_DEFAULT))
foil = _load_corpus(foil_path or (CORPUS_DIR / FOIL_DEFAULT))
g = rng.sample(golden, min(samples_per_side, len(golden)))
f = rng.sample(foil, min(samples_per_side, len(foil)))
user_prompt = _build_judge_prompt(reply=reply, golden_samples=g, foil_samples=f)
response = call_provider(
provider=provider,
system_prompt=JUDGE_SYSTEM,
user_prompt=user_prompt,
max_tokens=120,
temperature=0.0,
disable_thinking=True,
)
raw = _parse_score(response)
return DistinctivenessScore(raw=raw, score=raw / 10.0, judge_response=response)



except Exception:
return None
async def score_distinctiveness_async(
reply: str,
*,
Expand Down