Skip to content

[spark-compete] fix(observer): atomic temp+replace for _observer_seen.json to preserve dedup state on crash #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4gjnbzb4zf-sudo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[spark-compete] fix(observer): atomic temp+replace for _observer_seen.json to preserve dedup state on crash #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions evals/observer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,21 @@ def _save_seen(path: Path, seen: set[str]) -> None:
path.parent.mkdir(parents=True, exist_ok=True)
# Cap stored IDs to last 5000 to bound state size
capped = list(seen)[-5000:]
path.write_text(
json.dumps({"seen_trace_refs": capped}, indent=2),
encoding="utf-8",
)
# Atomic temp+replace so a crash mid-write cannot truncate the seen-trace
# state to empty. A torn state file would force the observer to re-issue
# paid meta-LLM calls on every previously-observed trace_ref on restart.
tmp = path.with_name(f".{path.name}.{os.getpid()}.tmp")
try:
tmp.write_text(
json.dumps({"seen_trace_refs": capped}, indent=2),
encoding="utf-8",
)
os.replace(tmp, path)
finally:
try:
tmp.unlink()
except FileNotFoundError:
pass


def _append_observation(path: Path, obs: Observation) -> None:
Expand Down