Docker project ready for review #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filling in the Dockerfile.train - adjusitng the train.py with the correct workingdir not to have bugs. - adjusting the README.md to view the progress of the assignment.
…ting a dockerhub account and storing the images.
abotzki
reviewed
Apr 24, 2025
|
|
||
| echo "build containers on VSC" | ||
|
|
||
| apptainer build --fakeroot python-train-sd.sif docker://saradufour/python-train-sd:v1.0.0 > $LOG_DIR/python-train-sd-OUT.log 2>&1 |
There was a problem hiding this comment.
you could also use a SBATCH statement to create log files
|
|
||
| # Check if the model file exists and wait until it does | ||
| model_path = '/app/models/iris_model.pkl' | ||
| model_path = '/my-workdir/iris_model.pkl' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry for the delay. Lost track of the deadline day.