Skip to content

RSDK-8989 - Always provide error on base channel close #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

RSDK-8989 - Always provide error on base channel close #391

merged 1 commit into from
Oct 15, 2024

Conversation

edaniels
Copy link
Contributor

@edaniels edaniels commented Oct 15, 2024 •
edited
Loading

@zaporter-work fwiw, this has been a bug prior to the new connect-es migration

Screenshot 2024-10-15 at 11 12 45 AM

@edaniels edaniels requested a review from a team as a code owner October 15, 2024 15:10
zaporter-work
zaporter-work approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@zaporter-work zaporter-work left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting -- must not have had the requisite conditions to trigger it. Don't remember ever seeing this in the console. Could go check an old PR dev env.

Thanks for the quick fix!

@edaniels edaniels changed the title Always provide error on base channel close RSDK-8989 - Always provide error on base channel close Oct 15, 2024
@njooma njooma self-requested a review October 15, 2024 15:40
njooma
njooma approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these methods need to be public? Since RPC is inside the SDK now, there aren't any external users of this.

If we can make these private/internal, then we don't have to worry about this stuff being breaking

@edaniels
Copy link
Contributor Author

Do these methods need to be public? Since RPC is inside the SDK now, there aren't any external users of this.

If we can make these private/internal, then we don't have to worry about this stuff being breaking

It's on the base channel which isn't to be used by external users (it's not exported) but it's composed by another class, so it needs to be public

@edaniels edaniels merged commit 203fecd into viamrobotics:main Oct 15, 2024
3 checks passed
@edaniels edaniels deleted the RSDK-8989 branch October 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njooma njooma njooma approved these changes

@purplenicole730 purplenicole730 Awaiting requested review from purplenicole730 purplenicole730 is a code owner automatically assigned from viamrobotics/sdk-netcode

+1 more reviewer

@zaporter-work zaporter-work zaporter-work approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edaniels @njooma @zaporter-work