Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3760: Move to tablesteps for complex content #4184

Merged
merged 4 commits into from
Apr 5, 2025

Conversation

npentrel
Copy link
Collaborator

@npentrel npentrel commented Apr 2, 2025

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Apr 2, 2025
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 4c07862
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67f038692613e000081b4778
😎 Deploy Preview https://deploy-preview-4184--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 31 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JessamyT
Copy link
Collaborator

JessamyT commented Apr 2, 2025

This has done something strange to tab indentation
image
and in places like https://deploy-preview-4184--viam-docs.netlify.app/operate/get-started/other-hardware/#test-your-module-locally the extra indentation makes the code blocks pretty narrow and thus less convenient to read

@@ -136,6 +145,9 @@ Authenticate your CLI session with Viam using one of the following options:

{{< /expand >}}

{{% /tablestep %}}
{{< /table >}}

The generator will create a folder containing stub files for your modular sensor component.
In the next section, you'll customize some of the generated files to support your sensor.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python tab below still needs tablestep formatting so it doesn't do this
image

Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npentrel npentrel merged commit c6c0966 into viamrobotics:main Apr 5, 2025
12 checks passed
Copy link

github-actions bot commented Apr 5, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants