Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mistakenly copied-and-pasted line #3849

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

penguinland
Copy link
Member

The ffmpeg camera doesn't do depth images, and the filters arguments certainly doesn't contain a path to a depth image. I suspect this line was mistakenly copied and pasted from somewhere else. The filters do contain an array of filter objects, though!

Seemed easier for me to fix myself than file a ticket for your team. 🙃

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 13, 2025
@viambot
Copy link
Member

viambot commented Jan 13, 2025

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3849

@penguinland
Copy link
Member Author

😬 I don't understand the failing CI check. Please LMK what I should do to fix it!

Copy link
Collaborator

@sguequierre sguequierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, Alan! LGTM. Don't worry about the failing check-- I'll merge this over it, it's just failing temporarily because of our docs revamp

@sguequierre sguequierre merged commit 787e12e into viamrobotics:main Jan 14, 2025
9 of 10 checks passed
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

@penguinland penguinland deleted the ffmpeg_camera branch January 14, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants