-
Notifications
You must be signed in to change notification settings - Fork 0
fix(AVO-3804): upgrade admin-core, and comp libs to esm #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
acbfbb3
fix(AVO-3804): upgrade admin-core, and comp libs to esm
bertyhell c354e20
fix(AVO-3804): fix pr remarks (wip)
bertyhell 89b77a3
ARC-3280: remove sorting of download columns
reunefe b1da66c
ARC-3280: Only display noDate message on request when not loading and…
reunefe 8333bde
Merge pull request #1342 from viaacode/bugfix/hermes-sprint-2-fixes
reunefe 5fa874c
4.0.13
reunefe af88845
fix(esm): fix typescript errors
bertyhell 9a0f2ad
Merge remote-tracking branch 'origin/master' into feature/upgrade-lib…
bertyhell f8861a3
fix(esm): fix issues with latest admin-core
bertyhell c0475a0
fix(esm): avoid loading admin routes in the fallback route
bertyhell e828220
fix(esm): bump admin-core to avoid @emotion/react error
bertyhell 81f29d9
fix(esm): fix pr remarks around react-query upgrade, admin route changes
bertyhell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "hetarchief-client", | ||
| "version": "4.0.12", | ||
| "version": "4.0.13", | ||
| "private": true, | ||
| "contributors": [ | ||
| "Bert Verhelst <[email protected]>", | ||
|
|
@@ -40,26 +40,26 @@ | |
| }, | ||
| "dependencies": { | ||
| "@emotion/cache": "11.11.0", | ||
| "@flowplayer/player": "3.3.0", | ||
| "@flowplayer/player": "3.32.1", | ||
| "@hookform/resolvers": "2.9.11", | ||
| "@meemoo/admin-core-ui": "4.7.2", | ||
| "@meemoo/react-components": "4.5.3", | ||
| "@meemoo/admin-core-ui": "5.2.12", | ||
| "@meemoo/react-components": "5.1.5", | ||
| "@react-hook/resize-observer": "1.2.5", | ||
| "@reduxjs/toolkit": "1.9.6", | ||
| "@studiohyperdrive/pagination": "1.0.0", | ||
| "@tanstack/react-query": "4.36.1", | ||
| "@tanstack/react-query": "5.90.7", | ||
| "@types/openseadragon": "3.0.10", | ||
| "@viaa/avo2-components": "5.4.1", | ||
| "@viaa/avo2-types": "3.4.2", | ||
| "@viaa/avo2-components": "6.2.2", | ||
| "@viaa/avo2-types": "5.0.9", | ||
| "autosize": "6.0.1", | ||
| "blend-promise-utils": "1.29.2", | ||
| "capture-stack-trace": "1.0.1", | ||
| "clsx": "2.0.0", | ||
| "copy-to-clipboard": "3.3.1", | ||
| "cors": "2.8.5", | ||
| "critters": "0.0.23", | ||
| "date-fns": "2.30.0", | ||
| "date-fns-tz": "2.0.0", | ||
| "date-fns": "3.6.0", | ||
| "date-fns-tz": "3.2.0", | ||
| "file-saver": "2.0.5", | ||
| "focus-trap-react": "8.11.0", | ||
| "i": "^0.3.7", | ||
|
|
@@ -85,20 +85,19 @@ | |
| "react-datepicker": "4.21.0", | ||
| "react-dom": "18.3.1", | ||
| "react-highlight-words": "0.20.0", | ||
| "react-hook-form": "7.46.2", | ||
| "react-hook-form": "7.66.0", | ||
| "react-infinite-scroll-component": "6.1.0", | ||
| "react-masonry-css": "1.0.16", | ||
| "react-modal": "3.14.4", | ||
| "react-page-split": "0.0.7", | ||
| "react-perfect-scrollbar": "1.5.8", | ||
| "react-popper": "2.3.0", | ||
| "react-range": "1.8.14", | ||
| "react-redux": "8.1.3", | ||
| "react-resizable-panels": "0.0.55", | ||
| "react-router": "5.3.4", | ||
| "react-router-dom": "5.3.4", | ||
| "react-resizable-panels": "3.0.6", | ||
| "react-router": "7.9.1", | ||
| "react-router-dom": "7.9.1", | ||
| "react-scrollbars-custom": "4.1.1", | ||
| "react-select": "5.7.4", | ||
| "react-select": "5.10.2", | ||
| "react-table": "7.7.0", | ||
| "react-to-string": "0.1.1", | ||
| "react-toastify": "9.1.3", | ||
|
|
@@ -176,7 +175,7 @@ | |
| "postcss-preset-env": "7.0.1", | ||
| "raf": "3.4.1", | ||
| "redux-mock-store": "1.5.4", | ||
| "sass": "^1.66.1", | ||
| "sass": "1.93.3", | ||
| "sass-loader": "12.4.0", | ||
| "slice-ansi": "4.0.0", | ||
| "style-loader": "3.3.1", | ||
|
|
@@ -189,7 +188,6 @@ | |
| "typescript": "5.1.6" | ||
| }, | ||
| "overrides": { | ||
| "@emotion/react": "11.11.1", | ||
| "@types/react": "18.2.22", | ||
| "@types/react-dom": "18.2.7", | ||
| "babel-plugin-macros": "3.1.0", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,26 +1,24 @@ | ||
| import type { IPagination } from '@studiohyperdrive/pagination'; | ||
| import { type UseQueryResult, useQuery } from '@tanstack/react-query'; | ||
|
|
||
| import { FoldersService } from '@account/services/folders'; | ||
| import type { FolderIeObject } from '@account/types'; | ||
| import { QUERY_KEYS } from '@shared/const/query-keys'; | ||
| import type { IPagination } from '@studiohyperdrive/pagination'; | ||
| import { type UseQueryResult, useQuery } from '@tanstack/react-query'; | ||
|
|
||
| export function useGetFolderMedia( | ||
| id: string | undefined, | ||
| searchInput: string | undefined, | ||
| page: number, | ||
| size: number | ||
| ): UseQueryResult<IPagination<FolderIeObject>> { | ||
| return useQuery( | ||
| [QUERY_KEYS.getCollectionMedia, searchInput, page, size], | ||
| () => { | ||
| ): UseQueryResult<IPagination<FolderIeObject> | undefined> { | ||
| return useQuery({ | ||
| queryKey: [QUERY_KEYS.getCollectionMedia, searchInput, page, size], | ||
| queryFn: () => { | ||
| if (id) { | ||
| return FoldersService.getById(id, searchInput, page, size); | ||
| } | ||
| return undefined; | ||
| }, | ||
| { | ||
| enabled: !!id, | ||
| retry: false, // Avoid delay when API returns 404 due to empty list | ||
| } | ||
| ); | ||
| enabled: !!id, | ||
| retry: false, // Avoid delay when API returns 404 due to empty list | ||
| }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,21 +1,20 @@ | ||
| import { type UseQueryResult, useQuery } from '@tanstack/react-query'; | ||
| import { useDispatch } from 'react-redux'; | ||
|
|
||
| import { FoldersService } from '@account/services/folders'; | ||
| import type { Folder } from '@account/types'; | ||
| import { QUERY_KEYS } from '@shared/const/query-keys'; | ||
| import { setFolders } from '@shared/store/ie-objects'; | ||
| import { type UseQueryResult, useQuery } from '@tanstack/react-query'; | ||
| import { useDispatch } from 'react-redux'; | ||
|
|
||
| export function useGetFolders(enabled = true): UseQueryResult<Folder[]> { | ||
| const dispatch = useDispatch(); | ||
|
|
||
| return useQuery<Folder[]>( | ||
| [QUERY_KEYS.getCollections], | ||
| async () => { | ||
| return useQuery<Folder[]>({ | ||
| queryKey: [QUERY_KEYS.getCollections], | ||
| queryFn: async () => { | ||
| const response = await FoldersService.getAll(); | ||
| dispatch(setFolders(response.items)); | ||
| return response.items || []; | ||
| }, | ||
| { enabled } | ||
| ); | ||
| enabled, | ||
| }); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,24 @@ | ||
| import { useQuery, type UseQueryResult } from '@tanstack/react-query'; | ||
| import { isEmpty, isNil } from 'lodash-es'; | ||
|
|
||
| import { QUERY_KEYS } from '@shared/const/query-keys'; | ||
| import { CampaignMonitorService } from '@shared/services/campaign-monitor-service'; | ||
| import type { GetNewsletterPreferencesResponse } from '@shared/types/newsletter'; | ||
| import { type UseQueryResult, useQuery } from '@tanstack/react-query'; | ||
| import { isEmpty, isNil } from 'lodash-es'; | ||
|
|
||
| export const useGetNewsletterPreferences = ( | ||
| email: string | undefined | ||
| ): UseQueryResult<GetNewsletterPreferencesResponse | null> => { | ||
| return useQuery([QUERY_KEYS.getNewsletterPreferences, email], () => { | ||
| if (isNil(email)) { | ||
| return null; | ||
| } | ||
| return useQuery({ | ||
| queryKey: [QUERY_KEYS.getNewsletterPreferences, email], | ||
| queryFn: () => { | ||
| if (isNil(email)) { | ||
| return null; | ||
| } | ||
|
|
||
| if (isEmpty(email)) { | ||
| throw new Error(`Given email can't be empty. Received email: ${email}`); | ||
| } | ||
| if (isEmpty(email)) { | ||
| throw new Error(`Given email can't be empty. Received email: ${email}`); | ||
| } | ||
|
|
||
| return CampaignMonitorService.getPreferences(email); | ||
| return CampaignMonitorService.getPreferences(email); | ||
| }, | ||
| }); | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.