Skip to content

fix: capture p2pp exit code correctly in e2e pipeline - #109

Open
markballew wants to merge 1 commit into
masterfrom
fix/exit-code-bug
Open

markballew wants to merge 1 commit into
masterfrom
fix/exit-code-bug

Conversation

@markballew

Copy link
Copy Markdown

Bug: || true masked the real exit code — $? always reported 0 even when p2pp failed. Fix: use set +e/set -e and capture P2PP_RC explicitly.

The `|| true` on the p2pp line meant $? always reported 0,
hiding real failures. Use set +e / set -e around the call and
capture the exit code explicitly.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot and Cursor Security Agent were not running on this PR after the first check poll, no applicable approval policy required human review, and no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant