Repository navigation
fix: capture p2pp exit code correctly in e2e pipeline - #109
Open
markballew wants to merge 1 commit into
Open
markballew wants to merge 1 commit into
markballew wants to merge 1 commit into
Conversation
The `|| true` on the p2pp line meant $? always reported 0, hiding real failures. Use set +e / set -e around the call and capture the exit code explicitly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Bug:
|| truemasked the real exit code — $? always reported 0 even when p2pp failed. Fix: use set +e/set -e and capture P2PP_RC explicitly.