Do slack invites direclty from nomos, don't involve slack-invite-automation service#341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #340
Needs two new environment variables:
NOMOS_SLACK_INVITE_TOKEN, which we'll need to dig out of the current https://github.com/vhs/slack-invite-automation container.NOMOS_SLACK_URL=vanhack.slack.comjust to keep this dynamic in case one day someone else comes along and uses nomos for their hackspace.I have tested the negative case, but since I don't have access to a slack key I haven't tested the positive cases yet. should work, but I will get a key and then confirm that before merging.