Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make working with cmake *alot* more convenient #14

Merged
merged 30 commits into from
Mar 30, 2018

Conversation

Squareys
Copy link
Contributor

@Squareys Squareys commented Apr 9, 2017

Hi everybody!

First of all: Thank you for creating this plugin! It served me well the last half a year. During that time I noticed some things that would be nice to have, some bugs and some minor annoyances.
The last three days I finally got around working on this plugin a bit and as a result here are my changes. High-Level summary of what I did:

  • Add vader.vim tests
  • Add CI configurations for Travis CI (Linux) and AppVeyor (Windows)
  • Update README.md to reflect previous contributions
  • Make this plugin help with using YouCompleteMe in CMake projects
  • Allow finding build directories from directory of file in current buffer if searching from working directory fails
  • Prevent clearing existing configurations implicitly (Can be horrible when working on larger projects)
  • Have build_dir stored per buffer to allow working with multiple CMake projects in one vim instance

For further information please refer to the commit history and commit messages, everything necessary should be explained there in detail.

I realize this grew to more commits than the project had in total, so I can fully understand if you are not happy with merging this. It would be amazing, though, if you could at least add a reference to my fork in the readme, if you decide not to accept my changes!

Thank you very much, kind regards,
Squareys.

PS: This PR is not compatible with #13

Squareys added 29 commits April 9, 2017 09:04
Signed-off-by: Squareys <[email protected]>
Fixes problems where the user "cd"s out of the directory in which he called
CMake() command, which would make the build dir invalid.

Signed-off-by: Squareys <[email protected]>
In some circumstances the user may have already configured a cmake project
with a certain generator or other variables, which would be overwritten
with the config values set with the g:cmake_* variables.

Instead the user should be required to do a clean build if this behaviour
is requested.

Signed-off-by: Squareys <[email protected]>
Otherwise they will be displayed and then disappear. This way you can re-
read the message using :messages

Signed-off-by: Squareys <[email protected]>
Fixed a typo, added doc for recently merged branches and added loads for
acknoledgements for people who I found had commits on this project.

Signed-off-by: Squareys <[email protected]>
If found and we are in the build/ directory itself, finddir() will return
the full path and not "".

Signed-off-by: Squareys <[email protected]>
Saves an addition string concatenation which reads nicer.

Signed-off-by: Squareys <[email protected]>
See vim documentation. Just have the user use :CMakeClean explicitly, some
projects have alot of configuration which should never get deleted by
accident when using :CMake.

Signed-off-by: Squareys <[email protected]>
Including Vader test and vim documentation

Signed-off-by: Squareys <[email protected]>
Useful when working with multple projects with different build dirs. Also
prevents re-searching for the build_dir if already found. Allows specifying
a autocommand when switching buffers.

Signed-off-by: Squareys <[email protected]>
Signed-off-by: Squareys <[email protected]>
@Squareys Squareys changed the title Make working with cmake Make working with cmake *alot* more convenient Apr 9, 2017
@Squareys
Copy link
Contributor Author

Squareys commented Apr 9, 2017

I almost forgot: In case you merge this, you should create the project on travis/AppVeyor (very straight-forward since the config is already there) and then change the badges in README.md to show the build status of your project instead of my fork ;)

@vhdirk vhdirk merged commit 3286418 into vhdirk:master Mar 30, 2018
@vhdirk vhdirk mentioned this pull request Mar 30, 2018
@vhdirk
Copy link
Owner

vhdirk commented Mar 30, 2018

Hi,
First of all, thanks for this large amount of work! And sorry that I did not get around to merging this sooner (or even reacting upon it).
Anyway, at long last its finally merged!

@Squareys
Copy link
Contributor Author

Hi @vhdirk !

Ever since I had quite a few more changes on top of these. I could try to rebase and make them integratable, but I fear that this may have diverged a lot...
I could try to apply #18 also, but I am unsure of when I will have time for all this.

jachjoe pushed a commit to jachjoe/vim-cmake that referenced this pull request May 2, 2023
Make working with cmake *alot* more convenient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants