Skip to content

Fix: Update E2E iteration tests to use valid PR with fresh artifacts #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pedropaulovc merged 1 commit into from
Jan 17, 2026
Merged

Fix: Update E2E iteration tests to use valid PR with fresh artifacts #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 21 additions & 21 deletions e2e/prod/iteration-mode/iteration-file-status.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { setupAuthState } from "../../fixtures/github-mocks";

test.describe("Iteration File Status", () => {
// Test for bug fix: files first modified in later iterations should show as "modified" not "added"
// Uses real PR #97 which has action/action.yml first modified in iteration 2
// Uses real PR #11 in codjiflo-e2e-test-repo which has target-file.yml first modified in iteration 2

// Prod mode configuration - uses real PR #97
const config = { owner: "pedropaulovc", repo: "codjiflo", prNumber: 97 };
// Prod mode configuration - uses real PR #11 in e2e test repo
const config = { owner: "pedropaulovc", repo: "codjiflo-e2e-test-repo", prNumber: 11 };

test.beforeEach(async ({ page }) => {
await setupAuthState(page);
Expand All @@ -16,9 +16,9 @@ test.describe("Iteration File Status", () => {
page,
}) => {
// This test verifies the "base equivalence" fix:
// - action/action.yml existed in the PR base but wasn't changed in iteration 1
// - action/action.yml was first modified in iteration 2
// - When viewing iteration 1, action/action.yml should NOT appear
// - target-file.yml existed in the PR base but wasn't changed in iteration 1
// - target-file.yml was first modified in iteration 2
// - When viewing iteration 1, target-file.yml should NOT appear
// - When viewing iteration 2, it should show as "M" (modified), not "A" (added)

const pageUrl = `/${config.owner}/${config.repo}/${String(config.prNumber)}`;
Expand All @@ -32,32 +32,32 @@ test.describe("Iteration File Status", () => {
const fileList = page.getByRole("navigation", { name: /Changed files/i });
await expect(fileList).toBeVisible();

const actionYmlItem = fileList.locator(".tree-item.file").filter({
hasText: /action\.yml/,
const targetFileItem = fileList.locator(".tree-item.file").filter({
hasText: /target-file\.yml/,
});

// --- Iteration 1: action/action.yml should NOT appear ---
// --- Iteration 1: target-file.yml should NOT appear ---
const iteration1Tab = page.getByTestId("iteration-tab-1");
await iteration1Tab.click();
await expect(iteration1Tab).toHaveClass(/selected/);

// action/action.yml should not be visible (wasn't modified in iteration 1)
await expect(actionYmlItem).toBeHidden();
// target-file.yml should not be visible (wasn't modified in iteration 1)
await expect(targetFileItem).toBeHidden();

// --- Iteration 2: action/action.yml should appear as "M" (modified) ---
// --- Iteration 2: target-file.yml should appear as "M" (modified) ---
const iteration2Tab = page.getByTestId("iteration-tab-2");
await iteration2Tab.click();
await expect(iteration2Tab).toHaveClass(/selected/);

// action/action.yml should now be visible
await expect(actionYmlItem).toBeVisible();
// target-file.yml should now be visible
await expect(targetFileItem).toBeVisible();

// Check the change-type indicator shows "M" (modified), not "A" (added)
const changeTypeIndicator = actionYmlItem.locator(".change-type");
const changeTypeIndicator = targetFileItem.locator(".change-type");
await expect(changeTypeIndicator).toHaveText("M");

// Also verify via aria-label that it says "modified" not "added"
const ariaLabel = await actionYmlItem.getAttribute("aria-label");
const ariaLabel = await targetFileItem.getAttribute("aria-label");
expect(ariaLabel).toContain("modified");
expect(ariaLabel).not.toContain("added");
});
Expand Down Expand Up @@ -94,15 +94,15 @@ test.describe("Iteration File Status", () => {
await expect(tab1).toHaveClass(/selected/);
await expect(tab2).toHaveClass(/selected/);

// action/action.yml should appear as "M" (modified), not "A" (added)
// target-file.yml should appear as "M" (modified), not "A" (added)
const fileList = page.getByRole("navigation", { name: /Changed files/i });
const actionYmlItem = fileList.locator(".tree-item.file").filter({
hasText: /action\.yml/,
const targetFileItem = fileList.locator(".tree-item.file").filter({
hasText: /target-file\.yml/,
});

await expect(actionYmlItem).toBeVisible();
await expect(targetFileItem).toBeVisible();

const changeTypeIndicator = actionYmlItem.locator(".change-type");
const changeTypeIndicator = targetFileItem.locator(".change-type");
await expect(changeTypeIndicator).toHaveText("M");
});
});
6 changes: 3 additions & 3 deletions e2e/prod/iteration-mode/iteration-tabs-ui.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@ import { test, expect } from "@playwright/test";
import { setupAuthState } from "../../fixtures/github-mocks";

test.describe("Iteration Tabs UI (Prod Mode)", () => {
// These tests require real iteration artifacts from PR #75
// These tests require real iteration artifacts from PR #11 in e2e test repo
const iterationTestPR = {
owner: "pedropaulovc",
repo: "codjiflo",
prNumber: 75,
repo: "codjiflo-e2e-test-repo",
prNumber: 11,
};

test.beforeEach(async ({ page }) => {
Expand Down
Loading