Skip to content

feat:add process_uptime_seconds metrics #6101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat:add process_uptime_seconds metrics #6101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions src/webservice/GetStatsHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@

#include "common/base/Base.h"
#include "common/stats/StatsManager.h"
#include "common/time/WallClock.h"
#include "webservice/Common.h"

namespace nebula {

// Process start time (auto-recorded via static initialization)
static const int64_t g_processStartTime = nebula::time::WallClock::fastNowInSec();

using nebula::stats::StatsManager;
using proxygen::HTTPMessage;
using proxygen::HTTPMethod;
Expand Down Expand Up @@ -96,14 +100,24 @@ folly::dynamic GetStatsHandler::getStats() const {
if (statNames_.empty()) {
// Read all stats
StatsManager::readAllValue(stats);
// Add process uptime metric to all stats
const int64_t uptimeSeconds = nebula::time::WallClock::fastNowInSec() - g_processStartTime;
addOneStat(stats, "process_uptime_seconds", uptimeSeconds);
} else {
for (auto& sn : statNames_) {
auto status = StatsManager::readValue(sn);
if (status.ok()) {
int64_t statValue = status.value();
addOneStat(stats, sn, statValue);
// Handle process uptime metrics specially
if (sn == "process_uptime_seconds") {
const int64_t uptimeSeconds = nebula::time::WallClock::fastNowInSec() - g_processStartTime;
addOneStat(stats, sn, uptimeSeconds);
} else {
addOneStat(stats, sn, status.status().toString());
// Handle regular metrics
auto status = StatsManager::readValue(sn);
if (status.ok()) {
const int64_t statValue = status.value();
addOneStat(stats, sn, statValue);
} else {
addOneStat(stats, sn, status.status().toString());
}
}
}
}
Expand Down