Skip to content

Conversation

@Egor-OSSRevival
Copy link

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: #3224

Description:

This PR enhances the FunctionManagerTest by adding comprehensive test cases for various return type functions. It includes tests for integer, float, string, boolean, and list return type functions, and also covers cases with variable argument types, non-existent functions, and incorrect argument types.

How do you solve it?

  • Added multiple test cases in FunctionManagerTest to cover:
    • Integer return type functions like abs
    • Double return type functions like sqrt, ceil, floor, round, cbrt, pow, sin, asin, hypot
    • String return type functions like toString, concat
    • Boolean return type functions like eq
    • List return type functions like split
    • Functions with variable argument types like max
    • Non-existent functions and incorrect argument types to ensure robust error handling

Special notes for your reviewer, ex. impact of this fix, design document, etc:

  • This enhancement increases the test coverage and ensures that the FunctionManager handles different return types and argument scenarios correctly.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

Enhanced FunctionManagerTest to include comprehensive test cases for various return type functions, improving test coverage and robustness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants