Skip to content

UI Improvement: Darkmode Component Accessibility & Hover Animation #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tanvichovatiya wants to merge 3 commits into
base: main
Choose a base branch
from
Open

UI Improvement: Darkmode Component Accessibility & Hover Animation #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41a8082
fix navbar layout
Tanvichovatiya Sep 21, 2025
7ed3c48
improve nav CSS with flex gap
Tanvichovatiya Oct 6, 2025
828b3d2
Enhanced Darkmode component: accessibility, semantic button, hover an…
Tanvichovatiya Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions src/components/Buttons/Darkmode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
import React, { useContext } from "react";
import { ThemeContext } from "../../Context/themeContext";
import sol from "../../Sun.png";
import lua from "../../Moon.png";
import SunIcon from "../../Sun.png";
import MoonIcon from "../../Moon.png";

function Darkmode() {
const Darkmode = () => {
const { theme } = useContext(ThemeContext);
return theme.mode === "light" ? (
<img src={lua} alt="lua icone" className="w-10"></img>
) : (
<img src={sol} alt="sol icone" className="w-10"></img>
const isLightMode = theme.mode === "light";

return (
<button
aria-label={`Switch to ${isLightMode ? "dark" : "light"} mode`}
className="w-10 h-10 focus:outline-none"
>
<img
src={isLightMode ? MoonIcon : SunIcon}
alt={isLightMode ? "Moon icon" : "Sun icon"}
className="w-full h-full object-contain transition-transform duration-300 hover:scale-110"
/>
</button>
);
}
};

export default Darkmode;
6 changes: 3 additions & 3 deletions src/components/Header.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const Header = ({ language, setLanguage, setInputSearch }) => {

return (
<Navbar id="header">
<Container className=" flex lg:flex-row flex-col justify-center items-center w-full px-4">
<Container className=" flex lg:flex-row flex-col justify-start items-center w-full px-8">
<Navbar.Brand href="/" className="d-none d-sm-block ">
{theme.mode === "light" ? (
<img src={logo_white} alt="Logo" className="w-24 h-24"></img>
Expand Down Expand Up @@ -81,9 +81,9 @@ const Header = ({ language, setLanguage, setInputSearch }) => {
<div
onClick={changeTheme}
className={
"cursor-pointer max-lg:!hidden hover:scale-105 transition-all ease-linear duration-200"
"cursor-pointer max-lg:hidden hover:scale-100 transition-all ease duration-300"
}
style={{ fontSize: "1.5rem" }}
style={{ fontSize: "1.6rem" }}
aria-hidden="true"
>
<Darkmode />
Expand Down
26 changes: 12 additions & 14 deletions src/components/Navigation.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,35 @@
/* ========================
Navigation Bar Styles
======================== */
.nav {
width: 100%;
display: flex; /* ensure flex layout */
flex-wrap: nowrap;
justify-content: center;
align-items: center;
padding: 0.5rem 0rem 0.5rem 0rem;
padding: 0.5rem 0; /* simplified shorthand */
}

/* Button container inside nav */
.nav__buttons {
display: flex;
width: auto;
}

.nav__buttons > * {
margin-left: 0.5rem;
gap: 0.5rem; /* use gap instead of margin for better spacing */
}

/* Mobile Breakpoints */
/* Use 768 instead of 576 since Pagination can get wide */
@media (max-width: 768px) {
.nav {
flex-direction: column;
flex-direction: column; /* stack vertically on small screens */
}

.nav__buttons > * {
margin-top: 0.5rem;
}

.nav__buttons > :first-child {
margin-left: 0rem;
.nav__buttons {
flex-direction: column;
gap: 0.5rem; /* consistent spacing */
}
}

/* Helpers */
/* Utility Class: Remove default padding/margin */
.noBuff {
padding: 0;
margin: 0;
Expand Down