Skip to content

Remove completed TODOs from publish script #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevmurray merged 1 commit into from
Jul 11, 2025
Merged

Remove completed TODOs from publish script #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/veritone-json-schemas/scripts/publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
#!/usr/bin/env bash

# TODO(km):
# - If no version number is provided, make one by incrementing the last version?
# - If --release is specified, get the ITSM ticket number and verify it is approved before proceeding

usage() {
cat <<EOF
Usage:
Expand Down Expand Up @@ -866,9 +862,6 @@ upload_to_getaiwarecom() {
# If neither archive nor upload is specified, default to both
[[ -z "$archive" && -z "$upload" ]] && { archive="--archive"; upload="--upload"; }

# TODO(km): this should be smarter about some things like:
# - If no version number is provided, make one by incrementing the last version

# Validate version argument
version="$1"
[[ -z "$version" ]] && { error "No version specified."; usage; exit 1; }
Expand Down