-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code copy #3
Conversation
GitOrigin-RevId: 456a21f1e2e4f2b56f6a66fb93ad44def2a4f81b
GitOrigin-RevId: 41d08f96f9a4b367a1fa68e49de30e96166a4c4a
GitOrigin-RevId: b8bebf065c6b2212c17d7d4dbfb8e5427b9e96d7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really want to sarcastically ask if you can break this into smaller PRs because this is too large 🙃
@alexlaurinmath is this meant to be merged into a single commit like this? I see 7 commits in this PR, most of them are merges of the copybara branch. I thought this was preserving history? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Scanned list of packages
✅ Scanned for internal identifiers
✅ Scanned for copy config files / README inclusion
🚀
I wasn't able to get history preservation to work. I think we see multiple commits because I'm using the same branch without deleting it? If this becomes a problem I'll either delete the branch or use a different one. |
Merging should be blocked on tests passing.