Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code copy #3

Merged
merged 7 commits into from
May 7, 2024
Merged

Initial code copy #3

merged 7 commits into from
May 7, 2024

Conversation

alexlaurinmath
Copy link
Contributor

Merging should be blocked on tests passing.

Copybara and others added 6 commits May 3, 2024 16:19
Copy link
Member

@bitwizeshift bitwizeshift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want to sarcastically ask if you can break this into smaller PRs because this is too large 🙃

@bitwizeshift
Copy link
Member

@alexlaurinmath is this meant to be merged into a single commit like this?

I see 7 commits in this PR, most of them are merges of the copybara branch. I thought this was preserving history?

Copy link
Member

@OliverCardoza OliverCardoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Scanned list of packages
✅ Scanned for internal identifiers
✅ Scanned for copy config files / README inclusion

🚀

@alexlaurinmath
Copy link
Contributor Author

@alexlaurinmath is this meant to be merged into a single commit like this?

I see 7 commits in this PR, most of them are merges of the copybara branch. I thought this was preserving history?

I wasn't able to get history preservation to work. I think we see multiple commits because I'm using the same branch without deleting it? If this becomes a problem I'll either delete the branch or use a different one.

@alexlaurinmath alexlaurinmath merged commit 334e45a into main May 7, 2024
1 check passed
@alexlaurinmath alexlaurinmath deleted the copybara branch May 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants