Skip to content

Add needed includes to vpr_signal_handler #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2025
Merged

Add needed includes to vpr_signal_handler #3313

merged 1 commit into from
Oct 16, 2025

Conversation

AmirhosseinPoolad
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad commented Oct 16, 2025 •
edited
Loading

vpr_signal_handler.cpp used some header files that were indirectly included. This commit directly adds those header files to vpr_signal_handler.

I also removed the unused includes. This file previously had some issues with the pre-release GCC-16 (See #3306) because unistd.h was not directly included. The ifdef for unix is based on similar code in vtr_util.cpp:

#if defined(__unix__)
#include <unistd.h> //For getpid()
#endif

@AmirhosseinPoolad
Add needed includes to vpr_signal_handler
9cb7dcc 
vpr_signal_handler.cpp used some header files that were indirectly included.
This commit directly adds those header files to vpr_signal_handler
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Oct 16, 2025
@amin1377 amin1377 self-requested a review October 16, 2025 20:22
amin1377
amin1377 approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Amir!

@AmirhosseinPoolad AmirhosseinPoolad merged commit 8627a34 into master Oct 16, 2025
30 checks passed
@AmirhosseinPoolad AmirhosseinPoolad deleted the signal_handled_include_fix branch October 16, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amin1377 amin1377 amin1377 approved these changes

Assignees

No one assigned

Labels

lang-cpp C/C++ code VPR VPR FPGA Placement & Routing Tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AmirhosseinPoolad @amin1377