librrgraph: add array operator #3298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a build error with gcc-16.
|
The changes look good, Mahesh. Thank you for updating the upstream code with the patch. |
|
@heshpdx: Since the function is marked as const, shouldn’t the return type, given that it’s returned by reference, also be const? |
I think you are right. |
|
We have a better patch. I will make a new PR soon. |
|
Sounds good. Thanks, Mahesh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build error with gcc-16, found via testing of the SPEC CPU code. @amin1377
We think it is related to this: https://gcc.gnu.org/pipermail/libstdc++/2025-September/063655.html