fix(release): settle confirm-main on the release leaf job, not the first 'release' match - #3103
Merged
Merged
Conversation
…rst 'release' match confirm_main waited for the first job whose name contained 'release'. With vergil-actions#905, cd-release adds release / package-matrix (always runs, finishes first) plus package-build/package-sign jobs, so the settle wait could end before release / release concluded and the release would fail falsely (a regression of the #1611 race). _settled_run_jobs now takes job matchers (predicates on the job name). confirm-main settles on _is_release_job (the leaf-segment matcher that already handles release / release and cd / release, #2001); confirm-develop keeps its substring match via _name_contains('docs'). Ref #3102
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Issue Linkage
Notes