[DRAFT] #260 update servers #535
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stift
force-pushed
the
260_update_servers
branch
13 times, most recently
from
6f082cd to
86fa6c0
Compare
Stift
force-pushed
the
260_update_servers
branch
from
86fa6c0 to
808c544
Compare
- use sqflite as cache database - store all item actions in cache - use virtual markers to distinct between saved and intermediate state - images are stored on device data instead of stream to reduce mem_usage - auto-discover when add + delete are done in cache (removes item from cache and never stores it)
Stift
force-pushed
the
260_update_servers
branch
from
808c544 to
589ad18
Compare
Stift
force-pushed
the
260_update_servers
branch
from
589ad18 to
1812c05
Compare
| @@ -0,0 +1,45 @@ | |||
| import 'package:gruene_app/app/services/converters.dart'; | |||
There was a problem hiding this comment.
My understanding was that feature specific services should also go to features/<feature>/services (so in this case features/campaign/services instead of the general app/services file to keep everything a little more organized and grouped together by feature. Perhaps I also understood something wrong here though, but I think we should decide on the file structure we want to have to avoid a mess.
What do you think? Also @volkramweber and @NikoHadouken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Proposed changes
Side effects
Testing
Resolved issues
Fixes: #260