565: Refactor news by extracting api, loading and error handling #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steffenkleinle
commented
Jan 10, 2025
| ), | ||
| ], | ||
| ), | ||
| return FutureLoadingScreen<NewsModel?>( |
There was a problem hiding this comment.
No changes except usage of FutureLoadingScreen instead of duplicated logic
steffenkleinle
commented
Jan 10, 2025
| return NewsCard(news: items[index]); | ||
| }, | ||
| ); | ||
| return FutureLoadingScreen( |
There was a problem hiding this comment.
No changes except usage of FutureLoadingScreen instead of duplicated logic
steffenkleinle
requested review from
NikoHadouken and
volkramweber
and removed request for
NikoHadouken
steffenkleinle
force-pushed
the
refactor-news
branch
from
5b01d14 to
f81151e
Compare
steffenkleinle
changed the title
steffenkleinle
force-pushed
the
refactor-news
branch
from
f81151e to
aa90ed8
Compare
567: Hide bookmarks until implemented
|
@steffenkleinle ❌ There are some small layout issues:
|
volkramweber
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Refactor news by extracting api, loading and error handling.
Proposed changes
FutureLoadingScreenErrorScreenSide effects
N/A
Testing
Test the news list and single news, reloading, being offline and opening news and by manually throwing errors.
Resolved issues
Fixes: N/A
Additional information
Fixes: #565
#504 still persists