feat(turborepo): support Bun #5934

nathanhammond · 2023-09-12T16:01:51Z

Enable using bun as both a package manager and a runtime.

vercel · 2023-09-12T16:02:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
examples-cra-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2023 3:10am
examples-vite-web	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Sep 15, 2023 3:10am

9 Ignored Deployments

Name	Status	Preview	Updated (UTC)
examples-basic-web	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-designsystem-docs	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-gatsby-web	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-kitchensink-blog	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-native-web	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-nonmonorepo	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-svelte-web	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
examples-tailwind-web	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am
turbo-site	⬜️ Ignored (Inspect)	Visit Preview	Sep 15, 2023 3:10am

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

vercel · 2023-09-12T16:02:16Z

Someone is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

gsoltis · 2023-09-12T19:40:12Z

crates/turborepo-lib/src/package_manager/bun.rs

+        let repo_root_path = AbsoluteSystemPathBuf::try_from(repo_root.path())?;
+
+        let lockfile_path = repo_root.path().join(LOCKFILE);
+        File::create(lockfile_path)?;


Non-blocking nit: we have .create_with_contents("") so we don't need to pull in std::fs::File.

chris-olszewski

Overall looks good to me. A few questions:

Are we expecting users to have print = "yarn" in their in their bunfig.toml in order to get lockfile based info for their repos? If so we should probably have some custom error messaging in the package graph building that suggests adding it when we notice they have a bun.lockb but no yarn.lock that we can read.
I'm pretty strongly against claiming we offer any sort of prune support until we can serialize enough info for some version of bun install to work. (Unless I'm reading the docs wrong and users can just bun install --yarn with only a yarn.lock and not need a bun.lockb)

crates/turborepo-lockfiles/src/bun/mod.rs

crates/turborepo-lockfiles/src/bun/ser.rs

cli/internal/packagemanager/npm.go

cli/internal/packagemanager/bun.go

crates/turborepo-lib/src/package_manager/mod.rs

nathanhammond · 2023-09-13T03:38:11Z

Are we expecting users to have print = "yarn" in their in their bunfig.toml in order to get lockfile based info for their repos? If so we should probably have some custom error messaging in the package graph building that suggests adding it when we notice they have a bun.lockb but no yarn.lock that we can read.

Nope, bun bun.lockb spits out the yarn lockfile, so I'm going to do it "just in time" every time. I don't want to ask users to have to do anything.

I'm pretty strongly against claiming we offer any sort of prune support until we can serialize enough info for some version of bun install to work. (Unless I'm reading the docs wrong and users can just bun install --yarn with only a yarn.lock and not need a bun.lockb)

I've started a thread in Slack on this to get full team input.

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

orca-security-us

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0 0 0 0	View in Orca

This reverts commit 26ec64c.

juliusmarminge · 2023-09-15T06:57:45Z

Thanks for shipping this so fast. Just tried out the canary and noticed some warnings:

Vercel detects the bun lockfile, but then proceeds using yarn, I had to manually set bun install as the install command to fix this:

On Vercel, I get an error/warning about no package manager being set in package.json. I believe you can't put bun in there, at least you get warnings saying that's not a valid option?

Running the suggested codegen command also errors. Might be worth gracefully exiting here.

EDIT: Actually running the canaray version of codegen package works:

But we do get the warning that bun isn't a valid option, can we just ignore that?

mpotane · 2023-09-15T07:44:15Z

same here look like corepack issue nodejs/corepack#307

nathanhammond · 2023-09-15T10:57:00Z

@juliusmarminge Thanks for the quick feedback!

Without doing any investigation, root cause here is likely the "adjusting default settings" step in there. Will investigate what happened. That step is not inside of turbo so your repository and turbo itself are probably fine. A few changes on our side and a redeploy to fix it.
We're intentionally breaking the rules about packageManager. That warning does not introduce bugs and can be safely ignored.
You did correctly identify that the codemod needed to be @canary.

Aside, the opener for the corepack PR is also a Vercel person. We're paying attention to it.

styfle · 2023-09-15T17:33:28Z

PR incoming

[fs-detectors] Add support for bun detection in monorepo vercel#10511

nathanhammond requested a review from chris-olszewski September 12, 2023 16:01

nathanhammond requested a review from a team as a code owner September 12, 2023 16:01

nathanhammond requested a review from mehulkar September 12, 2023 16:01

turbo-orchestrator bot added created-by: turborepo labels Sep 12, 2023

orca-security-us bot reviewed Sep 12, 2023

View reviewed changes

gsoltis requested review from chris-olszewski, gsoltis and tknickman and removed request for chris-olszewski September 12, 2023 17:31

gsoltis approved these changes Sep 12, 2023

View reviewed changes

chris-olszewski reviewed Sep 12, 2023

View reviewed changes

nathanhammond force-pushed the bun-support branch from 45f7cbe to 7e1e6b6 Compare September 13, 2023 01:56

nathanhammond force-pushed the bun-support branch from d893629 to da5e5e0 Compare September 13, 2023 05:06

tknickman mentioned this pull request Sep 13, 2023

feat(create-turbo): support bun (beta) #5943

Merged

2 tasks

orca-security-us bot reviewed Sep 14, 2023

View reviewed changes

nathanhammond and others added 9 commits September 15, 2023 10:56

Capture incremental state.

f6aeecd

compiles

50afda0

Refactor Go lockfile reading code.

af190ad

Weak type system means runtime panics.

31ee66b

Disable pruning for Bun.

f8a8f4c

SUpport bunfig for lockfile.

636b3c5

Revert "SUpport bunfig for lockfile."

1cb8710

This reverts commit 26ec64c.

Seamless reading of bun lockfile.

c39f452

Correct object name.

34cd7f9

Nathan Hammond added 2 commits September 15, 2023 10:56

Make Go lint happy.

0bed28a

Make sure that tests get duplicated too.

ed3f4ff

nathanhammond force-pushed the bun-support branch from 2ffa3c2 to ed3f4ff Compare September 15, 2023 02:56

nathanhammond merged commit 0239f38 into vercel:main Sep 15, 2023

chris-olszewski mentioned this pull request Oct 10, 2023

chore(lockfiles) avoid hand written reflection #6143

Merged

GhostOf0days mentioned this pull request Mar 22, 2024

[Feature] Change Map to CMUMap Style ScottyLabs/cmueats#473

Open

feat(turborepo): support Bun #5934

feat(turborepo): support Bun #5934

Uh oh!

Conversation

nathanhammond commented Sep 12, 2023 • edited by padmaia Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Sep 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orca-security-us bot left a comment

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

vercel bot commented Sep 12, 2023

Uh oh!

gsoltis Sep 12, 2023

Choose a reason for hiding this comment

Uh oh!

chris-olszewski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nathanhammond commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orca-security-us bot left a comment

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

orca-security-us bot left a comment

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

orca-security-us bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Orca Security Scan Summary

Uh oh!

juliusmarminge commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mpotane commented Sep 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nathanhammond commented Sep 15, 2023

Uh oh!

styfle commented Sep 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nathanhammond commented Sep 12, 2023 •

edited by padmaia

Loading

vercel bot commented Sep 12, 2023 •

edited

Loading

nathanhammond commented Sep 13, 2023 •

edited

Loading

orca-security-us bot left a comment •

edited

Loading

juliusmarminge commented Sep 15, 2023 •

edited

Loading

mpotane commented Sep 15, 2023 •

edited

Loading