Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Drives docs describe sizes in binary units (1 TiB default, 16 TiB quota: https://vercel.com/docs/sandbox/concepts/drives), but the CLI divides by 1024 and labels the result with SI units, so the default drive prints as
1 TB:formatBytesis shared bydrives,snapshots,sessions,lsandstop, so snapshot sizes and network transfer were mislabeled the same way. This changes the unit labels to KiB/MiB/GiB/TiB and leaves the math alone. Same drive from the patched build:Not touching the
max size:label wording here. It reads as a plan ceiling when it is the per-drive cap set by--max-size(a 16 TiB drive creates fine on Pro, 17 TiB getsThe maxSizeBytes value must not exceed the Drive quota of 17592186044416 bytes). Happy to fold a wording change in if we want one.Verification:
pnpm vitest runinpackages/sandbox, 19 files, 121 tests passed including the newtest/util/output.test.ts;pnpm typecheckclean; built CLI run against Internal Playground produced the output above.