Allow disabling HTTP request logs in dev server #74349
Open
+125
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
mohsen1
force-pushed
the
add-dev-request-logging-ignoring
branch
from
81f16af to
bc8aed5
Compare
|
IMO, should be called |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way to filter or disable incoming request logs in development. It adds a new
incomingRequestoption tologgingConfig, supporting both a simple boolean toggle and a configurableignorePattern. By default, logs remain enabled, preserving existing behavior.Notes:
•
loggingConfig.incomingRequest = falsefully disables incoming request logs.•
loggingConfig.incomingRequest.ignorePatternaccepts one or more regular expressions to selectively silence logs.• Covered by unit tests (
shouldLogIncomingRequest)Resolves the dev server’s verbose logging problem discussed in #65992 and complements the effort in #67590.