fix: add missing --dir flag to email build and export scripts #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The email app build was failing because the react-email CLI couldn't find the templates directory. Added --dir flag to specify the correct path to packages/email/templates, matching the dev script configuration. Fixes vercel#619
|
@jonathanagustin is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
nice one, thanks @jonathanagustin 🙏 |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--dirflag tobuildandexportscripts in apps/email/package.json../../packages/email/templatesdevscriptProblem
The email app build was failing because the react-email CLI defaults to looking for templates in
./emailsrelative to where the command runs, but the actual templates are inpackages/email/templates.Solution
Updated the scripts to explicitly specify the templates directory path using the
--dirflag.Fixes #619