Skip to content

Conversation

@jpvalery
Copy link
Contributor

@jpvalery jpvalery commented Jun 4, 2025

Description

The toggle on (unauthenticated) layout was disappearing when switching—this change prevents that

Checklist

  • My code follows the code style of this project.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation, if necessary.
  • I have added tests that prove my fix is effective or my feature works.
  • New and existing tests pass locally with my changes.

Screenshots (if applicable)

Before

CleanShot 2025-06-04 at 16 53 46

After

(do note that in my own version I have a different method for ModeToggle that switches between the theme rather than displaying a dropdown).

CleanShot 2025-06-04 at 16 54 38

@vercel
Copy link

vercel bot commented Jun 4, 2025

@jpvalery is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@QuentinFrc QuentinFrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternative is to override color for toggle on light theme but think your solution is the best

@haydenbleasel
Copy link
Collaborator

Nice one @jpvalery 🙏

@haydenbleasel haydenbleasel merged commit b1a9e3a into vercel:main Oct 6, 2025
1 of 6 checks passed
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

🚀 PR was released in v5.0.5 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released This issue/pull request has been released.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants