fix(eve): deliver subagent.called events to hooks - #2691
Open
NicoMoli wants to merge 2 commits into
Open
Conversation
Signed-off-by: Nicolas Molina <n_m09@hotmail.com>
Contributor
|
@NicoMoli is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
…-hooks Signed-off-by: Nicolas Molina <n_m09@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2223. Parent
subagent.calledevents reached the stream but bypassed authored hooks in plain and task dispatch modes. The shared emitter now sends the same stamped event to the stream and hooks inside the framework context, while logging post-start failures to prevent child dispatch replay.Validation
Focused dispatch and hook lifecycle integration coverage passes (31 tests), along with eve package typecheck, formatting, lint, invariant, and docs checks. The full unit run reached 6,619 passing tests but could not complete because generated
#compiledmodules were unavailable locally and the sandbox blocked one port-binding test; CI will cover the complete suite.Checklist
CONTRIBUTING.mdevepackagegit commit --signoff)Diff size
Docs — 2 files ·
+8 / -1Documents
subagent.calleddelivery and its replay-safe failure behavior, with the required patch changeset.Implementation — 3 files ·
+66 / -44Keeps the lifecycle change in the shared emitter and threads provider-committed session state through both callers.
Tests — 1 file ·
+114 / -24Uses a real context container to cover both dispatch modes, event identity, provider commits, and the throwing-hook replay boundary.