Skip to content

fix(eve): deliver subagent.called events to hooks - #2691

Open
NicoMoli wants to merge 2 commits into
vercel:mainfrom
NicoMoli:fix/subagent-called-hooks
Open

fix(eve): deliver subagent.called events to hooks#2691
NicoMoli wants to merge 2 commits into
vercel:mainfrom
NicoMoli:fix/subagent-called-hooks

Conversation

@NicoMoli

Copy link
Copy Markdown
Contributor

Summary

Closes #2223. Parent subagent.called events reached the stream but bypassed authored hooks in plain and task dispatch modes. The shared emitter now sends the same stamped event to the stream and hooks inside the framework context, while logging post-start failures to prevent child dispatch replay.

Validation

Focused dispatch and hook lifecycle integration coverage passes (31 tests), along with eve package typecheck, formatting, lint, invariant, and docs checks. The full unit run reached 6,619 passing tests but could not complete because generated #compiled modules were unavailable locally and the sandbox blocked one port-binding test; CI will cover the complete suite.

Checklist

  • This change was requested or approved by a maintainer
  • I ran the relevant checks from CONTRIBUTING.md
  • I added tests and documentation where relevant
  • I added a changeset if this touches the published eve package
  • DCO sign-off passes for every commit (git commit --signoff)

Diff size

Docs — 2 files · +8 / -1

Documents subagent.called delivery and its replay-safe failure behavior, with the required patch changeset.

Implementation — 3 files · +66 / -44

Keeps the lifecycle change in the shared emitter and threads provider-committed session state through both callers.

Tests — 1 file · +114 / -24

Uses a real context container to cover both dispatch modes, event identity, provider commits, and the throwing-hook replay boundary.

Signed-off-by: Nicolas Molina <n_m09@hotmail.com>
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

@NicoMoli is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

…-hooks

Signed-off-by: Nicolas Molina <n_m09@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subagent.called is in the hook event map but never delivered to hooks

1 participant