fix: Manual tool approvals reject inputs produced by Zod transforms - #21130
Open
ai-sdk-factory[bot] wants to merge 3 commits into
Open
ai-sdk-factory[bot] wants to merge 3 commits into
ai-sdk-factory[bot] wants to merge 3 commits into
Conversation
Co-authored-by: brennanbutler01 <64561607+brennanbutler01@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Manual approval continuations in the published
aipackage rejected transformed tool inputs in bothgenerateTextandstreamText, producing tool errors instead of executing approved tools.Root Cause
parseToolCallstored the schema output in message history, while approval revalidation treated that transformed output as fresh schema input. The reproduction confirmed this by transforming a string to a number, then failing revalidation with zero tool executions.Summary
Preserved the original schema input for transformed tool calls, then replayed schema validation and input refinement on continuation and verified that the result matched the approved input before execution.
Testing
Added Zod 3 and Zod 4 transform, object reshaping, refinement, tampering, and response-message persistence regression coverage.
End-to-end Validation
replay_original_reproduction— the immutablegenerateTextandstreamTextreproduction exited successfully, and the original failure signal was absent.Related Issues
Fixes #21091
Closes #21093