fix(google-vertex): allow 'vertex' as a key for providerOptions #10983
+523
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrammel
reviewed
Dec 9, 2025
lgrammel
reviewed
Dec 9, 2025
lgrammel
reviewed
Dec 9, 2025
lgrammel
reviewed
Dec 9, 2025
lgrammel
reviewed
Dec 10, 2025
Collaborator
|
Please add to migration guide. Are any changes to the google vertex provider docs necessary? |
lgrammel
approved these changes
Dec 10, 2025
Contributor
Author
|
added a migration guide - will be adding codemods in a follow up PR once this lands |
3 tasks
aayush-kapoor
added a commit
that referenced
this pull request
Dec 11, 2025
…e-vertex (#11049) ## Background Follow up to PR #10983 ## Summary Added codemods for the breaking change highlighted in the migration guide of the PR. ## Manual Verification Tests and fixtures were added ## Checklist - [x] Tests have been added / updated (for bug fixes / features) - [x] Documentation has been added / updated (for bug fixes / features) - [x] A _patch_ changeset for relevant packages has been added (for bug fixes / features - run `pnpm changeset` in the project root)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#7783
When providerOptions are defined in the vertex provider with the key
vertex, they are ignored and not sent in the request to the model; they only work withgooglekey.Summary
Allow the
vertexto be a valid key for setting providerOptions for vertex provider for consistency sakeManual Verification
test cases added
Checklist
pnpm changesetin the project root)Future Work
Need to add codemods for the changes in the migration guide
Related Issues
Fixes #7783