Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #922
When a popup's
initialFocusresolved to something that can't take focus, like a disabled button or a plain paragraph, focus stayed on the trigger. For a modal Dialog or Drawer that leaves focus behind the backdrop. The docs already say focus falls back to the content.After moving focus to the target, the popup now checks that focus landed in the target or the content. If it didn't, the content (which has
tabindex="-1") takes it. A target outside the popup that does take focus is left alone.Tests:
initial-focus-fallback.test.tscovers a disabled button and a non-focusable element, for Dialog and Popover. All 4 fail on main. The core suite passes.