Skip to content

fix(core): close the trigger menu when its empty part or last row unmounts - #915

Open
shadcn wants to merge 3 commits into
mainfrom
shadcn/fix-trigger-menu-empty-and-rows-unmount
Open

shadcn wants to merge 3 commits into
mainfrom
shadcn/fix-trigger-menu-empty-and-rows-unmount

Conversation

@shadcn

@shadcn shadcn commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #914

  • When the Empty part unmounts, it clears hasEmpty. The menu settles again, so an Empty that only one trigger renders no longer keeps an empty popup open for the next trigger, and no longer swallows Enter.
  • When rows unmount after the input that filtered them, as React children do, an open menu that has nothing left to show now closes.

Both new tests fail on main.

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ui Ready Ready Preview, v0 Nov 19, 2026 8:03pm UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trigger Menu: Empty part registration never clears, and unmounting rows doesn't re-settle

1 participant