-
Notifications
You must be signed in to change notification settings - Fork 199
Update README to reflect .env file naming #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yamz8
wants to merge
1
commit into
vercel-labs:main
Choose a base branch
from
yamz8:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Quick Start section now references
.envfor environment variables, but the detailed "Local Development Setup" section still references.env.local. This inconsistency will confuse developers during setup.View Details
Analysis
Documentation inconsistency: Quick Start references wrong environment file
What fails: README.md Quick Start section (line 46) instructs developers to "Set up .env with required variables" while the detailed "Local Development Setup" section (line 188) instructs to "Create a
.env.localfile with your values". This creates conflicting setup instructions for local development.How to reproduce:
.env.env.local.env, then encounters different instructions in detailed setupResult: Developers are confused about which file to use since Quick Start contradicts the detailed setup section.
Expected: Per Next.js environment variables documentation,
.env.localis the standard convention for local development - it allows developers to override defaults without committing sensitive values to version control. The gitignore pattern.env*is specifically designed to ignore.env.localfor local development.Fix: Updated line 46 to reference
.env.localto align with line 188 and follow Next.js best practices.