Skip to content

fix: restore glob matching for wait --url#1069

Open
hiSandog wants to merge 2 commits intovercel-labs:mainfrom
hiSandog:fix/wait-url-glob-matching
Open

fix: restore glob matching for wait --url#1069
hiSandog wants to merge 2 commits intovercel-labs:mainfrom
hiSandog:fix/wait-url-glob-matching

Conversation

@hiSandog
Copy link
Copy Markdown

Summary\n- restore glob-aware matching for in the native Rust implementation\n- preserve exact-match behavior when no wildcard syntax is used\n- add targeted tests for exact matches, , , and alternation\n\n## Why\n currently uses literal substring matching, so documented glob patterns like never resolve. This regressed from the earlier Playwright-based implementation.\n\n## Validation\n- added focused unit tests covering the expected URL matching semantics\n- ran a small local semantics check for the same matching logic against the new cases\n- I could not run on this machine because the Rust toolchain is not installed here\n\n## Notes\n- this keeps the fix narrow to rather than broadening into route/response-body matching in the same PR\n

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 29, 2026

Someone is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Copy Markdown
Collaborator

@ctate ctate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix — glob-to-regex logic is clean, well-tested, and e2e confirms it resolves the regression. Two things before merging:

  1. Clippy lint fix neededwhile let Some(next) = chars.next() at line 2790 should use for next in chars.by_ref(). This will fail CI.
  2. Use regex-lite instead of regex — the full crate is heavyweight for this use case; regex-lite is a lighter drop-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants