Skip to content

feat: add dashboard host support#1067

Open
chethanuk wants to merge 2 commits intovercel-labs:mainfrom
chethanuk:feat/dashboard-host-support
Open

feat: add dashboard host support#1067
chethanuk wants to merge 2 commits intovercel-labs:mainfrom
chethanuk:feat/dashboard-host-support

Conversation

@chethanuk
Copy link
Copy Markdown

Summary

  • add configurable host binding for the dashboard server so it can listen on a non-localhost interface when needed
  • pass the selected host through the CLI dashboard startup path instead of always binding to 127.0.0.1
  • update the dashboard frontend to derive API URLs from the current host and protocol instead of assuming localhost
  • use the exported dashboard port constant when deciding between same-origin session requests and cross-port requests

Validation

  • cd cli && cargo test
  • cd cli && cargo fmt -- --check
  • cd cli && cargo clippy
  • cd packages/dashboard && pnpm build

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 28, 2026

@chethanuk is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@ThomasK33
Copy link
Copy Markdown
Contributor

I think you'll also need to update:

const ws = new WebSocket(`ws://localhost:${port}`);

Comment on lines +8 to +13
const { protocol, hostname, port } = window.location;
if (!port || port === String(DASHBOARD_PORT)) {
return `${protocol}//${hostname}:${DASHBOARD_PORT}`;
}

return `${protocol}//${hostname}:${DASHBOARD_PORT}`;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this going to always return ${protocol}//${hostname}:${DASHBOARD_PORT}?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants