fix(cli): preserve macOS Chrome symlinks during install#1058
Open
niieani wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(cli): preserve macOS Chrome symlinks during install#1058niieani wants to merge 1 commit intovercel-labs:mainfrom
niieani wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Contributor
|
@niieani is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On macOS,
agent-browser get url(and other commands) could fail immediately afteragent-browser installwith Chrome exiting before it wroteDevToolsActivePort.Observed error:
Auto-launch failed: Chrome exited early (exit code: unknown) without writing DevToolsActivePortdlopenfailures forGoogle Chrome for Testing Framework.frameworkRoot Cause
The installer used a custom ZIP extraction loop for Chrome for Testing archives. On macOS, those app bundles contain framework symlinks. The custom extractor wrote every non-directory ZIP entry as a regular file, so symlink entries were materialized as plain files containing the symlink target text instead of real symlinks.
That corrupted the extracted Chrome bundle. When macOS tried to load the framework, required framework paths such as
Resources,Versions/Current, andGoogle Chrome for Testing Frameworkno longer resolved correctly, so Chrome exited before startup completed.Fix
zipcrate extraction path, which preserves symlinks and applies safer path handlingextract_unwrapped_root_dir(...)so the archive root still gets unwrapped without maintaining custom path-rewrite logicVerification
cargo test extract_zip_cargo run -- get url