fix(cli): trust native OS certificate roots for installer HTTP requests#1056
Open
niieani wants to merge 1 commit intovercel-labs:mainfrom
Open
fix(cli): trust native OS certificate roots for installer HTTP requests#1056niieani wants to merge 1 commit intovercel-labs:mainfrom
niieani wants to merge 1 commit intovercel-labs:mainfrom
Conversation
Contributor
|
@niieani is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-browser installfails on enterprise-managed networks that TLS-intercept HTTPS traffic with a locally trusted corporate CA.The CLI currently builds
reqwestandtokio-tungsteniteagainstrustls-tls-webpki-roots, which only trusts the bundled Mozilla/webpki root set. That bypasses the macOS/Windows system trust store, so requests that succeed incurlor the browser can still fail insideagent-browserwith:Failed to fetch version info: error sending request for url (https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions-with-downloads.json)This patch switches both crates to native OS trust roots and enables reqwest's system proxy features.
Why this change
agent-browser installbehind enterprise TLS interception / SSL inspectionVerification
cargo checkcargo run -- installafter the patch; it successfully fetched the Chrome-for-Testing manifest and started downloading Chrome instead of failing during the initial HTTPS request